HTML API: Preserve XMP raw text serialization#55
Open
sirreal wants to merge 1 commit into
Open
Conversation
sirreal
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
force-pushed
the
fix/xmp-rawtext-serialize
branch
from
3aed331 to
ccdb111
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves
XMPcontents literally when serializing withWP_HTML_Processor::serialize_token().Root cause
XMPis parsed as raw text, but serialization was sending its contents through the ordinary text escaping path. That turned characters such as<into<, and because character references are not decoded inside XMP raw text, serializing and re-parsing changed the document contents.Behavioral impact
XMP contents now serialize like other literal raw-text contents. Parser-derived XMP text is safe to emit literally here because it came from the tokenizer's raw-text state: character references were not decoded, NUL bytes are already represented as
U+FFFD, and the matching</xmp>terminator is appended by the serializer rather than accepted from the raw text.Validation
vendor/bin/phpunit --group html-api --filter 'test_xmp_contents_are_not_escaped|test_replaces_null_bytes_appropriately'-> OK, 10 tests, 11 assertionsvendor/bin/phpunit --group html-api --filter Tests_HtmlApi_WpHtmlProcessor_Serialize-> OK, 87 tests, 161 assertionsvendor/bin/phpcs src/wp-includes/html-api/class-wp-html-processor.php tests/phpunit/tests/html-api/wpHtmlProcessor-serialize.php-> OK